Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Synapses to Synapses #133

Closed
denisalevi opened this issue Jul 16, 2018 · 3 comments
Closed

Add support for Synapses to Synapses #133

denisalevi opened this issue Jul 16, 2018 · 3 comments

Comments

@denisalevi
Copy link
Member

In brian2 one can create Synapses object which target Synapses objects. We currently get an

NotImplementedError: Cannot retrieve the values of state variables in standalone code before the simulation has been run.

error. This fails a bunch of test suite tests.
The reason is, that we need the IDs of the target group of a SynapticPathway in order to create our connectivity matrix (which is split by groups of post IDs). To get those, we need access to state variables of the SynapticPathway objects target group, which is a Synapse in the case of synapses to synapses connections. And we can't access Synapse variables before synapse creation and our current implementation fills those target group variables from python side (before the network is run), which gives us aboves error. I've tried to fix this but it was not straight forward and I'm moving on to more urgent tasks. Check the synapses_to_synapses_support branch for my first try. It needs some rearranging, such that the SynapticPathway classes (in cpp) target_start/target_end variables are some variables that are set from cpp side after synapse generation templates are run.

Maybe we also don't need my additional parameters in the SynapticPathway class (see commits below) and can just work with the owner.target.start variable in the synapses_initialise_template.

denisalevi added a commit that referenced this issue Jul 16, 2018
Problem is, that we need access to target variables, which gives an
error when the target is a `Synapse`, see #133
@denisalevi
Copy link
Member Author

Maybe relevant? brian-team/brian2@6e8acd1b

@denisalevi
Copy link
Member Author

Here are two PRs I came across related to Brian2 changes for synapse to synapse connections: brian-team/brian2#715 and brian-team/brian2#854.

@denisalevi
Copy link
Member Author

This was fixed in PR #186.

Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant