Add single precision support #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`i`/`j` have `_idx` as index, we need to check for them directly
denisalevi
added a commit
that referenced
this pull request
Jul 16, 2018
denisalevi
added a commit
that referenced
this pull request
Jun 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #37.
Our brian2 submodule now tracks the
float32_supportbranch at my brian2 fork (denisalevi/brian2). This way we have the single precision support that we need and can easily pull any changes in the brian-team/brian2@float32_support branch. But if that branch stays unmerged, we can also merge in the updated master branch when needed. I don't see an easier solution right now if we want the single preference support.The tests are passing except for the known issues and an additional issue when connecting synapses to synapses (not a new bug, just overseen before, see #133 ).
We can now also run all tests with single precision preference.