Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build error #102

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Fix build error #102

merged 1 commit into from
Jan 20, 2025

Conversation

brianc
Copy link
Owner

@brianc brianc commented Jun 19, 2024

Apparently merging 6 year old PRs has the potential to fail CI. WHO KNEW?

@brianc brianc merged commit 6e248dd into master Jan 20, 2025
5 checks passed
@cesco69
Copy link
Contributor

cesco69 commented Jan 22, 2025

the CI always fail for node 20 and 22 because package.json and package-lock.json are not aligned. Into package.json is required "nan": "2.22.0", into package-lock.json "nan": "2.19.0" see:

https://github.com/brianc/node-libpq/actions/runs/12875055764/job/35895669921#step:5:7

the solution is a npm install and publish the updated package-lock.json

@brianc
Copy link
Owner Author

brianc commented Jan 24, 2025

nice yeah sorry for the delay got this fix here now. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants