Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPD-46389 Rework data set serialization (filters) #158764

Closed
wants to merge 21 commits into from

Conversation

dsanz
Copy link

@dsanz dsanz commented Feb 12, 2025

Continuation of #158684 where

  • We inline as much as we can, to pack logic into bigger methods for scaling, minimizing the number of class attributes to those really shared.
  • Review variable naming in tests so that i) everything has FDS in it and ii) we no longer use Impl in variables
  • Defer variable declaration till it's used. This provides more cohesive units of logic inside big methods

@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@brianchandotcom
Copy link
Owner

@dsanz Please resend on top of dsanz#95

@dsanz
Copy link
Author

dsanz commented Feb 14, 2025

see #158861

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants