LPD-37787 Filtering using r_<relationshipName>_c_<objectName>ERC is not working properly #158839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…C field was being translated to the ID, so the sorting was really performed by ID.
… done in SortField (portal-odata module). I have created a new EntityModel for a String reference to a different field
…ers does not affect those tests
… of the relationship field and assert it is the expected value before starting with the test
|
To conserve resources, the PR Tester does not automatically run for every pull. If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed. If your pull was never tested, comment "ci:test" to run the PR Tester for this pull. |
This was referenced Feb 14, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #158791
@dannielraposo
@liferay-headless
Original pull request comment:
Initial Approach liferay-headless#2460
The first attempt to fix this involved modifying the query by adding a new inner join for this case. While technically feasible, this approach was quite complex.
Solution in this PR
The new solution leverages the fact that for a many-to-one relationship, the field r_cERC is always equivalent to /externalReferenceCode, which is already implemented and functional.
By modifying the filterableAndSortableFieldNameFunction of the entity field to utilize this existing workaround, the filter now works as intended without the need for additional joins or complex query adjustments.
See the following Jira Ticket: LPD-37787