Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmp: exit(2) on failure #307

Merged
merged 1 commit into from
Oct 31, 2023
Merged

cmp: exit(2) on failure #307

merged 1 commit into from
Oct 31, 2023

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Oct 29, 2023

  • Fix exit code for file open failure
  • style1: access $volume numerically
  • style2: sprinkle more exit code constants
  • EX_USAGE could possibly be merged into EX_FAILURE or given another value, but I left it alone

@mknos
cmp: exit(2) on failure
32dd2e5 
* Fix exit code for file open failure
* style1: access $volume numerically
* style2: sprinkle more exit code constants
* EX_USAGE could possibly be merged into EX_FAILURE or given another value, but I left it alone
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: cmp The cop program labels Oct 29, 2023
@briandfoy briandfoy self-assigned this Oct 31, 2023
@briandfoy briandfoy merged commit ef3e348 into briandfoy:master Oct 31, 2023
1 check passed
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Oct 31, 2023
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: cmp The cop program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mknos @briandfoy