Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmp: support reading STDIN #310

Merged
merged 1 commit into from
Nov 4, 2023
Merged

cmp: support reading STDIN #310

merged 1 commit into from
Nov 4, 2023

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Nov 4, 2023

  • Standard cmp treats file argument '-' as standard input
  • Add POD entry to mention this feature
  • FILE1 and FILE2 become $fh1 and $fh2 respectively
  • Validate number arguments skip1 and skip2 early, before accessing file arguments
  • Perform stat() comparisons between files only if both files are regular
  • STDIN doesn't support seek(), so implement "skip" with sysread() in this case
  • Now I can do...

echo ello > C
echo hello | perl cmp C - 0 1

* Standard cmp treats file argument '-' as standard input
* FILE1 and FILE2 become $fh1 and $fh2 respectively
* Validate number arguments skip1 and skip2 early, before accessing file arguments
* Perform stat() comparisons between files only if both files are regular
* STDIN doesn't support seek(), so implement "skip" with sysread() in this case
* Now I can do...

echo ello > C
echo hello | perl cmp C - 0 1
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: cmp The cop program labels Nov 4, 2023
@briandfoy briandfoy self-assigned this Nov 4, 2023
@briandfoy briandfoy merged commit 88da0fc into briandfoy:master Nov 4, 2023
1 check passed
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Nov 9, 2023
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Program: cmp The cop program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants