Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mail: duplicated VISUAL code #323

Merged
merged 1 commit into from
Nov 15, 2023
Merged

mail: duplicated VISUAL code #323

merged 1 commit into from
Nov 15, 2023

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Nov 14, 2023

  • Introduce main::vipath() to avoid duplicated access of $ENV{VISUAL}
  • Catch failure to spawn VISUAL editor by checking system() return value
  • Delete "print Dumper" statements which were silently failing (maybe ancient debug code)
  • When re-opening tmpfile in edit mode, file should be in read mode not write mode
  • editor::edit() is invoked by the 'm' command to write a new message, then the special ~v command loads the buffer in vi
  • editor::edit() input loop is terminated by a line with only a '.'
  • Add File::Temp, as done in main::visual()

@mknos
mail: duplicated VISUAL code
676b9e5 
* Introduce main::vipath() to avoid duplicated access of $ENV{VISUAL}
* Catch failure to spawn VISUAL editor by checking system() return value
* Delete "print Dumper" statements which were silently failing (maybe ancient debug code)
* When re-opening tmpfile in edit mode, file should be in read mode not write mode
* editor::edit() is invoked by the 'm' command to write a new message, then the special ~v command loads the buffer in vi
* editor::edit() input loop is terminated by a line with only a '.'
* Add File::Temp, as done in main::visual()
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: mail The mail program labels Nov 14, 2023
@briandfoy briandfoy self-assigned this Nov 15, 2023
@briandfoy briandfoy merged commit 5676921 into briandfoy:master Nov 15, 2023
1 check passed
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Nov 16, 2023
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@briandfoy briandfoy

Labels
Program: mail The mail program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mknos @briandfoy