Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tar: raise error for directory argument to -f #337

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Nov 21, 2023

  • Adding die() for directory argument ensures tar doesn't exit with a success code
  • Test command: perl tar -tf .
  • Found when testing against GNU tar

* Adding die() for directory argument ensures tar doesn't exit with a success code
* Test command: perl tar -tf .
* Found when testing against GNU tar
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: tar The tar program labels Nov 21, 2023
Copy link
Owner

@briandfoy briandfoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be improved with the more sophisticated exits we've been doing, but this is good enough for now.

@briandfoy briandfoy merged commit 469549e into briandfoy:master Nov 21, 2023
1 check passed
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Nov 21, 2023
@briandfoy briandfoy self-assigned this Nov 21, 2023
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Program: tar The tar program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants