Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ed: implement ';' addressing mode #792

Merged
merged 1 commit into from
Nov 9, 2024
Merged

ed: implement ';' addressing mode #792

merged 1 commit into from
Nov 9, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Nov 9, 2024 •
edited
Loading

  • ";" by itself is taken to mean current address to end, i.e. ".,$"
  • "A1;A2" expression is the same as "A1,A2"
  • ";A2" expression works like ".,A2"
  • I tested the following combinations...

,p ---> all lines
%p ---> all lines
;p ---> current line to end
1,p ---> only line 1
1%p ---> not supported
1;p ---> only line 1
1,2p ---> range 1-2
1%2p ---> not supported
1;2p ---> range 1-2
,2p ---> range 1-2
%2n ---> range 1-2
;20p ---> range current line to 20 (error if current>20)

@mknos
ed: implement ';' addressing mode
b05f44b 
* ";" address by itself is taken to mean current address to end, i.e. ".,$"
* "A1;A2" expression is the same as "A1,A2"
* ";A2" expression works like ".,A2"
* I tested the following combinations...

,p   ---> all lines
%p   ---> all lines
;p   ---> current line to end
1,p  ---> only line 1
1%p  ---> not supported
1;p  ---> only line 1
1,2p ---> range 1-2
1%2p ---> not supported
1;2p ---> range 1-2
,2p  ---> range 1-2
%2n  ---> range 1-2
;20p ---> range current line to 20 (error if current>20)
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: ed The ed program labels Nov 9, 2024
@mknos mknos temporarily deployed to automated_testing November 9, 2024 04:17 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 9, 2024 04:17 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 9, 2024 04:17 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 9, 2024 04:17 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 9, 2024 04:17 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 9, 2024 04:17 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 9, 2024 04:17 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 9, 2024 04:17 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 9, 2024 04:17 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 9, 2024 04:17 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 9, 2024 04:17 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 9, 2024 04:17 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 9, 2024 04:17 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 9, 2024 04:17 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 9, 2024 04:17 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 9, 2024 04:17 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 9, 2024 04:17 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 9, 2024 04:17 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 9, 2024 04:17 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 9, 2024 04:18 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Nov 9, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11753248235

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 73.069%
Totals Coverage Status
Change from base Build 11738096177: -0.7%
Covered Lines: 350
Relevant Lines: 479
💛 - Coveralls

1 similar comment
@coveralls
Copy link

coveralls commented Nov 9, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11753248235

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 73.069%
Totals Coverage Status
Change from base Build 11738096177: -0.7%
Covered Lines: 350
Relevant Lines: 479
💛 - Coveralls

@briandfoy briandfoy self-assigned this Nov 9, 2024
@briandfoy briandfoy removed the Priority: low get to this whenever label Nov 9, 2024
@briandfoy briandfoy merged commit 03dae73 into briandfoy:master Nov 9, 2024
22 of 23 checks passed
@briandfoy
Copy link
Owner

changes: implement ';' addressing mode

@briandfoy briandfoy added the Status: accepted The fix is accepted label Nov 9, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: ed The ed program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy