Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ls: avoid invalid closedir() #801

Merged
merged 1 commit into from
Nov 12, 2024
Merged

ls: avoid invalid closedir() #801

merged 1 commit into from
Nov 12, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Nov 12, 2024

  • When temporarily enabling warnings.pm I observed a warning in DirEntries(): closedir() attempted on invalid dirhandle $dh
  • opendir() was always called even if the file was not a directory
  • Delay the opendir() call until we know that we don't want to list a regular file
  • opendir() should not happen if running "ls -d", or if the argument to DirEntries() is not a directory

@mknos
ls: avoid invalid closedir()
b5ed60e 
* When temporarily enabling warnings.pm I observed a warning in DirEntries(): closedir() attempted on invalid dirhandle $dh
* The way the code was written, opendir() was always called even if the file was not a directory
* Delay the opendir() call until we know that we don't want to list a regular file
* opendir() should not happen if running "ls -d", or if the argument to DirEntries() is not a directory
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: ls The ls program labels Nov 12, 2024
@mknos mknos temporarily deployed to automated_testing November 12, 2024 04:58 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 12, 2024 04:58 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 12, 2024 04:58 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 12, 2024 04:58 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 12, 2024 04:58 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 12, 2024 04:58 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 12, 2024 04:58 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 12, 2024 04:58 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 12, 2024 04:58 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 12, 2024 04:58 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 12, 2024 04:58 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 12, 2024 04:58 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 12, 2024 04:58 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 12, 2024 04:58 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 12, 2024 04:58 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 12, 2024 04:58 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 12, 2024 04:58 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 12, 2024 04:58 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 12, 2024 04:58 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 12, 2024 04:59 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Nov 12, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11790995344

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 73.069%
Totals Coverage Status
Change from base Build 11774186393: -0.7%
Covered Lines: 350
Relevant Lines: 479
💛 - Coveralls

@briandfoy briandfoy self-assigned this Nov 12, 2024
briandfoy
briandfoy approved these changes Nov 12, 2024
View reviewed changes
bin/ls Show resolved Hide resolved
@briandfoy briandfoy merged commit c67fc0d into briandfoy:master Nov 12, 2024
22 of 23 checks passed
@briandfoy briandfoy removed the Type: enhancement improve a feature that already exists label Nov 12, 2024
@briandfoy briandfoy added the Type: bug an existing feature does not work label Nov 12, 2024
@briandfoy
Copy link
Owner

changes: don't automatically opendir everything

@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Nov 12, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: ls The ls program Status: released there is a new release with this fix Type: bug an existing feature does not work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy