Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grep: add -I flag #815

Merged
merged 1 commit into from
Nov 17, 2024
Merged

grep: add -I flag #815

merged 1 commit into from
Nov 17, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Nov 17, 2024

  • BSD and GNU versions have an -I option for ignoring binary files, i.e. treating binary files as if they don't match
  • test1: perl grep BASH /bin/bash ---> match, suppress text
  • test2: perl grep -a BASH /bin/bash ---> match, show text
  • test3: perl grep -q BASH /bin/bash ---> match, suppress all output
  • test4: perl grep -I BASH /bin/bash text.txt ---> match on text.txt but not /bin/bash

@mknos
grep: add -I flag
6b803bb 
* BSD and GNU versions have an -I option for ignoring binary files, i.e. treating binary files as if they don't match
* test1: perl grep BASH /bin/bash ---> match, suppress text
* test2: perl grep -a BASH /bin/bash ---> match, show text
* test3: perl grep -q BASH /bin/bash ---> match, suppress all output
* test4: perl grep -I BASH /bin/bash text.txt ---> match on text.txt but not /bin/bash
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: grep The grep program labels Nov 17, 2024
@mknos mknos temporarily deployed to automated_testing November 17, 2024 00:08 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 17, 2024 00:08 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 17, 2024 00:08 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 17, 2024 00:08 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 17, 2024 00:08 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 17, 2024 00:08 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 17, 2024 00:08 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 17, 2024 00:08 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 17, 2024 00:08 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 17, 2024 00:08 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 17, 2024 00:08 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 17, 2024 00:08 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 17, 2024 00:08 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 17, 2024 00:08 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 17, 2024 00:08 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 17, 2024 00:08 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 17, 2024 00:08 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 17, 2024 00:08 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 17, 2024 00:08 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 17, 2024 00:09 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Nov 17, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11874275932

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 73.069%
Totals Coverage Status
Change from base Build 11868626694: -0.7%
Covered Lines: 350
Relevant Lines: 479
💛 - Coveralls

@briandfoy briandfoy added the Type: compatability make it work like GNU or BSD label Nov 17, 2024
@briandfoy briandfoy self-assigned this Nov 17, 2024
@briandfoy
Copy link
Owner

changes: add -I (capital i) switch to ignore binary files

@briandfoy briandfoy merged commit 8509f78 into briandfoy:master Nov 17, 2024
22 of 23 checks passed
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Nov 17, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: grep The grep program Status: released there is a new release with this fix Type: compatability make it work like GNU or BSD Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy