Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mail: more reliably find vi command #823

Merged
merged 1 commit into from
Nov 19, 2024
Merged

mail: more reliably find vi command #823

merged 1 commit into from
Nov 19, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Nov 19, 2024

  • On Android I have Termux, and vi is installed as /data/data/com.termux/files/usr/bin/vi
  • Remove the assumption that vi is installed under /usr/bin
  • With this patch, perl will look for vi within $PATH
  • Tested on OpenBSD and Termux/Android
  • Environment variable $VISUAL still takes precedence if it is set

@mknos
mail: more reliably find vi command
a67b6cf 
* On Android I have Termux, and vi is installed as /data/data/com.termux/files/usr/bin/vi
* Remove the assumption that vi is installed under /usr/bin
* With this patch, perl will look for vi within $PATH
* Tested on OpenBSD and Termux/Android
* Environment variable $VISUAL still takes precedence if it is set
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: mail The mail program labels Nov 19, 2024
@mknos mknos temporarily deployed to automated_testing November 19, 2024 03:53 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 19, 2024 03:53 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 19, 2024 03:53 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 19, 2024 03:53 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 19, 2024 03:53 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 19, 2024 03:53 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 19, 2024 03:53 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 19, 2024 03:53 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 19, 2024 03:53 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 19, 2024 03:53 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 19, 2024 03:53 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 19, 2024 03:53 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 19, 2024 03:53 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 19, 2024 03:53 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 19, 2024 03:53 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 19, 2024 03:53 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 19, 2024 03:53 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 19, 2024 03:53 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 19, 2024 03:53 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 19, 2024 03:54 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Nov 19, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11905921745

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 73.069%
Totals Coverage Status
Change from base Build 11903396689: -0.7%
Covered Lines: 350
Relevant Lines: 479
💛 - Coveralls

@briandfoy briandfoy merged commit 4427b73 into briandfoy:master Nov 19, 2024
22 of 23 checks passed
@briandfoy
Copy link
Owner

changes: use VISUAL for the path to vi, or look for vi in the PATH

@briandfoy briandfoy removed the Priority: low get to this whenever label Nov 19, 2024
@briandfoy briandfoy added the Status: accepted The fix is accepted label Nov 19, 2024
@briandfoy briandfoy self-assigned this Nov 19, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: mail The mail program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy