Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cp -i: continue on prompt #827

Merged
merged 1 commit into from
Nov 20, 2024
Merged

cp -i: continue on prompt #827

merged 1 commit into from
Nov 20, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Nov 20, 2024

  • cp can copy multiple files to a destination
  • It is not an error for the user to type "n" to not clobber an existing file when running "cp -i"
  • Previously if I type "n", cp exits with a failure code and ignores the remaining files I want to copy
  • This patch is for the scenario where an external cp command is not found
%mkdir dest && perl cp -v a.c ar dest && perl cp -i a.c ar dest
a.c -> dest/a.c
ar -> dest/ar
overwrite dest/a.c? (y/n [n]) [n] n
overwrite dest/ar? (y/n [n]) [n] y
%echo $?
0

@mknos
cp -i: continue on prompt
029b7e8 
* cp can copy multiple files to a destination
* It is not an error for the user to type "n" to not clobber an existing file when running (cp -i)
* Previously if I type "n" cp will exit with a failure code and ignore the remaining files I want to copy

%mkdir dest && perl cp -v a.c ar dest && perl cp -i a.c ar dest
a.c -> dest/a.c
ar -> dest/ar
overwrite dest/a.c? (y/n [n]) [n] n
overwrite dest/ar? (y/n [n]) [n] y
%echo $?
0
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: cp The cp command labels Nov 20, 2024
@mknos mknos temporarily deployed to automated_testing November 20, 2024 01:26 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 20, 2024 01:26 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 20, 2024 01:26 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 20, 2024 01:26 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 20, 2024 01:26 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 20, 2024 01:26 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 20, 2024 01:26 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 20, 2024 01:26 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 20, 2024 01:26 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 20, 2024 01:26 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 20, 2024 01:26 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 20, 2024 01:26 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 20, 2024 01:26 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 20, 2024 01:26 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 20, 2024 01:26 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 20, 2024 01:26 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 20, 2024 01:26 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 20, 2024 01:26 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 20, 2024 01:26 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 20, 2024 01:26 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Nov 20, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11924937169

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 73.069%
Totals Coverage Status
Change from base Build 11914339203: 0.0%
Covered Lines: 350
Relevant Lines: 479
💛 - Coveralls

@briandfoy briandfoy self-assigned this Nov 20, 2024
@briandfoy briandfoy merged commit 616a2db into briandfoy:master Nov 20, 2024
23 checks passed
@briandfoy briandfoy added Type: bug an existing feature does not work and removed Type: enhancement improve a feature that already exists labels Nov 20, 2024
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Nov 20, 2024
@briandfoy
Copy link
Owner

changes: cp -i will continue to next file if there is an error.

@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: cp The cp command Status: released there is a new release with this fix Type: bug an existing feature does not work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy