Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ed: getAddr() vs maxline() #831

Merged
merged 1 commit into from
Nov 22, 2024
Merged

ed: getAddr() vs maxline() #831

merged 1 commit into from
Nov 22, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Nov 22, 2024

  • When adding getAddr() call to edMove() I noticed getAddr() doesn't raise error for n>maxline case
  • This logic was only in input() before, but it seems more correct for getAddr() to check the maxline limit
  • Also add missing check in edMove() for stray characters leftover after calling getAddr(); the argument to m should be a single address so anything remaining is invalid input
  • test: 1,2m.A ---> "A" suffix invalid after "."

@mknos
ed: getAddr() vs maxline()
9271e0b 
* When adding getAddr() call to edMove() I noticed getAddr() doesn't raise error for n>maxline case
* This logic was only in input() before, but it seems more correct for getAddr() to check the maxline limit
* Also add missing check in edMove() for stray characters leftover after calling getAddr(); the argument to m should be a single address so anything remaining is invalid input
* test: 1,2m.A ---> "A" suffix invalid after "."
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: ed The ed program labels Nov 22, 2024
@mknos mknos temporarily deployed to automated_testing November 22, 2024 03:21 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 22, 2024 03:21 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 22, 2024 03:21 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 22, 2024 03:21 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 22, 2024 03:21 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 22, 2024 03:21 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 22, 2024 03:21 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 22, 2024 03:21 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 22, 2024 03:21 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 22, 2024 03:21 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 22, 2024 03:21 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 22, 2024 03:21 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 22, 2024 03:21 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 22, 2024 03:21 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 22, 2024 03:21 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 22, 2024 03:21 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 22, 2024 03:21 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 22, 2024 03:21 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 22, 2024 03:21 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 22, 2024 03:21 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Nov 22, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11965849573

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 73.805%
Totals Coverage Status
Change from base Build 11965376118: 0.0%
Covered Lines: 355
Relevant Lines: 481
💛 - Coveralls

@briandfoy briandfoy merged commit 7468f09 into briandfoy:master Nov 22, 2024
23 checks passed
@briandfoy briandfoy self-assigned this Nov 22, 2024
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Nov 22, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: ed The ed program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy