Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fold: remove assert in adj_col() #835

Merged
merged 1 commit into from
Nov 25, 2024
Merged

fold: remove assert in adj_col() #835

merged 1 commit into from
Nov 25, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Nov 25, 2024

  • When running fold without -b flag, adj_col() is used---called through fold_file()
  • "fold -b" is a different algorithm and does not use adj_col()
  • Remove the $Byte_Only check in adj_col() because this can never happen
  • Also make the usage() function more standard by not taking a parameter

@mknos
fold: remove assert in adj_col()
22f6baf 
* When running fold without -b flag, adj_col() is used
* "fold -b" is a different algorithm and does not use adj_col()
* Remove the $Byte_Only check in adj_col() because this can never happen
* Also make the usage() function more standard by not taking a parameter
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: fold The fold program labels Nov 25, 2024
@mknos mknos temporarily deployed to automated_testing November 25, 2024 00:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 00:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 00:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 00:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 00:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 00:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 00:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 00:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 00:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 00:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 00:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 00:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 00:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 00:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 00:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 00:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 00:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 00:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 00:32 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 00:33 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Nov 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12001004889

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 73.069%
Totals Coverage Status
Change from base Build 11992872685: -0.7%
Covered Lines: 350
Relevant Lines: 479
💛 - Coveralls

@briandfoy briandfoy merged commit 5e7631e into briandfoy:master Nov 25, 2024
22 of 23 checks passed
@briandfoy
Copy link
Owner

changes: improve usage message (no longer takes a parameter)

@briandfoy briandfoy self-assigned this Nov 25, 2024
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Nov 25, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: fold The fold program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy