Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spell: variable name alias #838

Merged
merged 2 commits into from
Nov 25, 2024
Merged

spell: variable name alias #838

merged 2 commits into from
Nov 25, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Nov 25, 2024 •
edited
Loading

  • Avoid having two variables called $dict_file, one global and one in a loop
  • The default path for dictionary becomes DICT_FILE
  • Option "+dict2" scans an extra dictionary as well as DICT_FILE
  • Option "-d dict2" scans dict2 instead of DICT_FILE
  • Fix the loop so "spell +extra1 +extra2 novella.txt" works properly; the splice() broke the array index for the next loop iteration

@mknos
spell: variable name alias
7908419 
* Avoid having two variables called $dict_file, one global and one in a loop
* The default path for dictionary becomes DICT_FILE
* Argument "+dict2" scans an extra dictionary as well as DICT_FILE
* Option "-d dict2" scans dict2 instead of DICT_FILE
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: spell The spell program labels Nov 25, 2024
@mknos mknos temporarily deployed to automated_testing November 25, 2024 06:13 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 06:13 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 06:13 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 06:13 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 06:13 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 06:13 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 06:13 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 06:13 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 06:13 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 06:13 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 06:13 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 06:13 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 06:13 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 06:13 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 06:13 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 06:13 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 06:13 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 06:13 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 06:13 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 06:13 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Nov 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12004479566

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 73.069%
Totals Coverage Status
Change from base Build 11992872685: -0.7%
Covered Lines: 350
Relevant Lines: 479
💛 - Coveralls

@mknos mknos temporarily deployed to automated_testing November 25, 2024 06:24 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 06:24 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 06:24 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 06:24 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 06:24 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 06:24 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 06:24 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 06:24 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 06:24 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 06:24 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 06:24 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 06:24 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 06:24 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 06:24 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 06:24 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 06:24 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 06:24 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 06:24 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 06:24 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 25, 2024 06:24 — with GitHub Actions Inactive
@briandfoy briandfoy merged commit ba57adb into briandfoy:master Nov 25, 2024
21 of 22 checks passed
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Nov 25, 2024
@briandfoy briandfoy self-assigned this Nov 25, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: spell The spell program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy