Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

od: factor dump_line() #853

Merged
merged 1 commit into from
Dec 3, 2024
Merged

od: factor dump_line() #853

merged 1 commit into from
Dec 3, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Dec 3, 2024

  • The -v flag works the same as for hexdump command, displaying all lines including duplicated input
  • diffdata() compares the current line with previous line; if the -v flag is given there's no need to call it
  • Save $lastline if we're not in verbose mode and we saw a difference in the data
  • $ml becomes true when we saw a duplicate; this prevents '*' from being printed multiple times

@mknos
od: factor dump_line()
0128dbf 
* The -v flag works the same as for hexdump command, i.e. display all lines including duplicated input
* diffdata() compares current line to previous line; if -v flag is given there's no need to call it
* Save $lastline if we're not in verbose mode and if we saw a difference in the data
* $ml becomes true when we saw a duplicate; this prevents '*' from being printed multiple times
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: od The od program labels Dec 3, 2024
@mknos mknos temporarily deployed to automated_testing December 3, 2024 06:55 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 3, 2024 06:55 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 3, 2024 06:55 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 3, 2024 06:55 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 3, 2024 06:55 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 3, 2024 06:55 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 3, 2024 06:55 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 3, 2024 06:55 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 3, 2024 06:55 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 3, 2024 06:55 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 3, 2024 06:55 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 3, 2024 06:55 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 3, 2024 06:55 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 3, 2024 06:55 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 3, 2024 06:55 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 3, 2024 06:55 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 3, 2024 06:55 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 3, 2024 06:55 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 3, 2024 06:55 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 3, 2024 06:56 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Dec 3, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12134481847

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 72.464%
Totals Coverage Status
Change from base Build 12132325538: -0.7%
Covered Lines: 350
Relevant Lines: 483
💛 - Coveralls

@briandfoy briandfoy merged commit aff8388 into briandfoy:master Dec 3, 2024
22 of 23 checks passed
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Dec 4, 2024
@briandfoy briandfoy self-assigned this Dec 4, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: od The od program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy