Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hexdump: warn for directories #858

Merged
merged 1 commit into from
Dec 5, 2024
Merged

hexdump: warn for directories #858

merged 1 commit into from
Dec 5, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Dec 5, 2024

  • Avoid fatal error for directory arguments
  • Print a warning for a directory, then proceed to next argument
  • Use case tested: hexdump -C . .. file.txt

@mknos
hexdump: warn for directories
fe760fa 
* Avoid fatal error for directory arguments
* Print a warning for a directory, then proceed to next argument
* Use case tested: hexdump -C . .. file.txt
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: hexdump The hexdump program labels Dec 5, 2024
@mknos mknos temporarily deployed to automated_testing December 5, 2024 05:47 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 5, 2024 05:47 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 5, 2024 05:47 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 5, 2024 05:47 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 5, 2024 05:47 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 5, 2024 05:47 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 5, 2024 05:47 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 5, 2024 05:47 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 5, 2024 05:47 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 5, 2024 05:47 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 5, 2024 05:47 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 5, 2024 05:47 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 5, 2024 05:47 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 5, 2024 05:47 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 5, 2024 05:47 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 5, 2024 05:47 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 5, 2024 05:47 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 5, 2024 05:47 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 5, 2024 05:47 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 5, 2024 05:48 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Dec 5, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12174001761

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 72.464%
Totals Coverage Status
Change from base Build 12157171498: -0.7%
Covered Lines: 350
Relevant Lines: 483
💛 - Coveralls

@briandfoy briandfoy self-assigned this Dec 5, 2024
@briandfoy briandfoy merged commit bc0c5d5 into briandfoy:master Dec 5, 2024
22 of 23 checks passed
@briandfoy
Copy link
Owner

changes: don't die for directory argument; warn and move to next argument

@briandfoy briandfoy added Status: accepted The fix is accepted Status: released there is a new release with this fix and removed Priority: low get to this whenever Status: accepted The fix is accepted labels Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: hexdump The hexdump program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy