Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ed: standard exit code #863

Merged
merged 1 commit into from
Dec 6, 2024
Merged

ed: standard exit code #863

merged 1 commit into from
Dec 6, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Dec 6, 2024

  • When running an ed script the exit code is important
  • If any command in the script fails, edWarn() will be called and $Error will be set; this should translate to a failure exit code
  • Tested against GNU version (both tests show successful commands after the failed command)
#test1: q command after invalid address error
470
*H
*100p
?
invalid address
*10p
	/* this? */
*q
%echo $?
1

#test2: wq command after invalid address error
470
*H
*100p
?
invalid address
*1,2wq new.txt
39
%echo $?
1

@mknos
ed: standard exit code
127a87c 
* When running an ed script the exit code is important
* If any command in the script fails, edWarn() will be called and $Error will be set; this should translate to a failure exit code
* Tested against GNU version

#test1: q command after invalid address error
470
*H
*100p
?
invalid address
*10p
	/* this? */
*q
%echo $?
1

#test2: wq command after invalid address error
470
*H
*100p
?
invalid address
*1,2wq new.txt
39
%echo $?
1
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: ed The ed program labels Dec 6, 2024
@mknos mknos temporarily deployed to automated_testing December 6, 2024 02:37 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 6, 2024 02:37 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 6, 2024 02:37 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 6, 2024 02:37 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 6, 2024 02:37 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 6, 2024 02:37 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 6, 2024 02:37 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 6, 2024 02:37 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 6, 2024 02:37 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 6, 2024 02:37 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 6, 2024 02:37 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 6, 2024 02:38 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 6, 2024 02:38 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 6, 2024 02:38 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 6, 2024 02:38 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 6, 2024 02:38 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 6, 2024 02:38 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 6, 2024 02:38 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 6, 2024 02:38 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 6, 2024 02:38 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Dec 6, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12191896722

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 72.464%
Totals Coverage Status
Change from base Build 12185242343: 0.0%
Covered Lines: 350
Relevant Lines: 483
💛 - Coveralls

@briandfoy briandfoy self-assigned this Dec 6, 2024
@briandfoy briandfoy merged commit fb6adf6 into briandfoy:master Dec 6, 2024
23 checks passed
@briandfoy
Copy link
Owner

changes: always exit with 1 for failure

@briandfoy briandfoy added Status: accepted The fix is accepted Type: bug an existing feature does not work Status: released there is a new release with this fix and removed Priority: low get to this whenever Type: enhancement improve a feature that already exists Status: accepted The fix is accepted labels Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: ed The ed program Status: released there is a new release with this fix Type: bug an existing feature does not work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy