Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mail: -f usage forbids extra args #870

Merged
merged 1 commit into from
Dec 9, 2024
Merged

mail: -f usage forbids extra args #870

merged 1 commit into from
Dec 9, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Dec 9, 2024

  • If mail command is invoked with arguments it assumes those are addresses to send mail to, but running "mail -f mbox" is not compatible
  • Raise an error and print usage string, as done in OpenBSD version
  • Also use catfile() when constructing a default value for mailbox path

@mknos
mail: -f usage forbids extra args
8f3c5eb 
* If mail command is invoked with arguments it assumes those are addresses to send mail to, but running "mail -f mbox" is not compatible
* Raise an error and print usage string, as done in OpenBSD version
* Also use catfile() when constructing a default value for mailbox path
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: mail The mail program labels Dec 9, 2024
@mknos mknos temporarily deployed to automated_testing December 9, 2024 06:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 9, 2024 06:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 9, 2024 06:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 9, 2024 06:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 9, 2024 06:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 9, 2024 06:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 9, 2024 06:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 9, 2024 06:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 9, 2024 06:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 9, 2024 06:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 9, 2024 06:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 9, 2024 06:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 9, 2024 06:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 9, 2024 06:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 9, 2024 06:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 9, 2024 06:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 9, 2024 06:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 9, 2024 06:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 9, 2024 06:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 9, 2024 06:31 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Dec 9, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12230207069

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 72.464%
Totals Coverage Status
Change from base Build 12229907280: -0.7%
Covered Lines: 350
Relevant Lines: 483
💛 - Coveralls

@briandfoy briandfoy merged commit a85b1bf into briandfoy:master Dec 9, 2024
22 of 23 checks passed
@briandfoy
Copy link
Owner

changes: -f usage forbids extra args

@briandfoy briandfoy removed the Type: enhancement improve a feature that already exists label Dec 9, 2024
@briandfoy briandfoy added Type: bug an existing feature does not work Type: compatability make it work like GNU or BSD labels Dec 9, 2024
@briandfoy briandfoy self-assigned this Dec 9, 2024
@briandfoy briandfoy added Status: accepted The fix is accepted Status: released there is a new release with this fix and removed Priority: low get to this whenever Status: accepted The fix is accepted labels Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: mail The mail program Status: released there is a new release with this fix Type: bug an existing feature does not work Type: compatability make it work like GNU or BSD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy