Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

touch: -t0 is invalid #876

Merged
merged 1 commit into from
Dec 17, 2024
Merged

touch: -t0 is invalid #876

merged 1 commit into from
Dec 17, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Dec 17, 2024

  • Truth check for option -t argument prevented validation in parse_time() from running
  • "touch -t 0" isn't valid because a timespec requires >1 character
  • Style: remove "next" statement on utime() failure because there is no subsequent code to skip

@mknos
touch: -t0 is invalid
d9a0849 
* Truth check for option -t argument prevented validation in parse_time() from running
* "touch -t 0" isn't valid because timespec requires >1 character
* Style: remove "next" statement on utime() failure because there is no subsequent code to skip
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: touch The touch program labels Dec 17, 2024
@mknos mknos temporarily deployed to automated_testing December 17, 2024 01:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 17, 2024 01:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 17, 2024 01:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 17, 2024 01:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 17, 2024 01:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 17, 2024 01:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 17, 2024 01:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 17, 2024 01:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 17, 2024 01:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 17, 2024 01:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 17, 2024 01:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 17, 2024 01:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 17, 2024 01:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 17, 2024 01:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 17, 2024 01:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 17, 2024 01:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 17, 2024 01:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 17, 2024 01:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 17, 2024 01:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 17, 2024 01:30 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Dec 17, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12364574477

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 72.464%
Totals Coverage Status
Change from base Build 12352391146: -0.7%
Covered Lines: 350
Relevant Lines: 483
💛 - Coveralls

@briandfoy briandfoy self-assigned this Dec 17, 2024
@briandfoy briandfoy merged commit 0cd97dc into briandfoy:master Dec 17, 2024
22 of 23 checks passed
@briandfoy briandfoy added the Type: bug an existing feature does not work label Dec 17, 2024
@briandfoy briandfoy removed the Type: enhancement improve a feature that already exists label Dec 17, 2024
@briandfoy
Copy link
Owner

changes: check -t argument for definedness, not truth

@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: touch The touch program Status: accepted The fix is accepted Type: bug an existing feature does not work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy