Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

touch: options -r and -t are incompatible #888

Merged
merged 1 commit into from
Jan 1, 2025
Merged

touch: options -r and -t are incompatible #888

merged 1 commit into from
Jan 1, 2025

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Jan 1, 2025

  • Interpret options -r and -t as mutually exclusive
  • The standards document provides a usage string which clarifies this [1]
  • Previously if -r and -t were used together, one would be silently ignored
  • Ignoring one option is confusing because it's unclear to the user which time value was actually used
  • Style change: quote some hash keys to satisfy vim syntax highlighting ("m}" was seen as the start of a regex)
  1. https://pubs.opengroup.org/onlinepubs/9699919799/utilities/touch.html

@mknos
touch: options -r and -t are incompatible
d8515ce 
* Interpret options -r and -t as mutually exclusive
* The standards document provides a usage string which clarifies this [1]
* Previously if -r and -t were used together, one would be silently ignored
* Ignoring one option is confusing because it's unclear to the user which time value was actually used

1. https://pubs.opengroup.org/onlinepubs/9699919799/utilities/touch.html
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: touch The touch program labels Jan 1, 2025
@mknos mknos temporarily deployed to automated_testing January 1, 2025 01:54 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 1, 2025 01:54 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 1, 2025 01:54 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 1, 2025 01:54 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 1, 2025 01:54 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 1, 2025 01:54 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 1, 2025 01:54 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 1, 2025 01:54 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 1, 2025 01:54 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 1, 2025 01:54 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 1, 2025 01:54 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 1, 2025 01:54 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 1, 2025 01:54 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 1, 2025 01:54 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 1, 2025 01:54 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 1, 2025 01:54 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 1, 2025 01:54 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 1, 2025 01:54 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 1, 2025 01:54 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 1, 2025 01:55 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Jan 1, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 12566053305

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 72.464%
Totals Coverage Status
Change from base Build 12398496491: 0.0%
Covered Lines: 350
Relevant Lines: 483
💛 - Coveralls

@briandfoy briandfoy merged commit a0beaf3 into briandfoy:master Jan 1, 2025
23 checks passed
@briandfoy
Copy link
Owner

changes: -r and -t are mutually exclusive and together will throw an error

@briandfoy briandfoy self-assigned this Jan 1, 2025
@briandfoy briandfoy added Status: accepted The fix is accepted Type: bug an existing feature does not work and removed Priority: low get to this whenever Type: enhancement improve a feature that already exists labels Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: touch The touch program Status: accepted The fix is accepted Type: bug an existing feature does not work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy