Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

diff: fix output_ed_diff() param declaration #895

Merged
merged 1 commit into from
Jan 2, 2025
Merged

diff: fix output_ed_diff() param declaration #895

merged 1 commit into from
Jan 2, 2025

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Jan 2, 2025

  • The number of parameters for Hunk::output_ed_diff() doesn't vary, i.e. $diff_type always follows after $fileref2
  • Remove comment which adds more confusion than clarity
  • Stack trace for diff -f
. = Hunk::output_ed_diff(ref(Hunk), ref(ARRAY), ref(ARRAY), 'REVERSE_ED') called from file 'diff' line 340
. = Hunk::output_diff(ref(Hunk), ref(ARRAY), ref(ARRAY), 'REVERSE_ED') called from file 'diff' line 185
  • Stack trace for diff -e
. = Hunk::output_ed_diff(ref(Hunk), ref(ARRAY), ref(ARRAY), 'ED') called from file 'diff' line 190

@mknos
diff: fix output_ed_diff() param declaration
8d0b658 
* The number of parameters for Hunk::output_ed_diff() doesn't vary, i.e. $diff_type always follows after $fileref2
* Remove comment which adds more confusion than clarity
* Stack trace for diff -f 
. = Hunk::output_ed_diff(ref(Hunk), ref(ARRAY), ref(ARRAY), 'REVERSE_ED') called from file 'diff' line 340
. = Hunk::output_diff(ref(Hunk), ref(ARRAY), ref(ARRAY), 'REVERSE_ED') called from file 'diff' line 185

* Stack trace for diff -e
. = Hunk::output_ed_diff(ref(Hunk), ref(ARRAY), ref(ARRAY), 'ED') called from file 'diff' line 190
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: diff The diff program labels Jan 2, 2025
@mknos mknos temporarily deployed to automated_testing January 2, 2025 02:27 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 2, 2025 02:27 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 2, 2025 02:27 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 2, 2025 02:27 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 2, 2025 02:27 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 2, 2025 02:27 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 2, 2025 02:27 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 2, 2025 02:27 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 2, 2025 02:27 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 2, 2025 02:27 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 2, 2025 02:27 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 2, 2025 02:27 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 2, 2025 02:27 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 2, 2025 02:27 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 2, 2025 02:27 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 2, 2025 02:27 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 2, 2025 02:27 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 2, 2025 02:27 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 2, 2025 02:27 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 2, 2025 02:28 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Jan 2, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 12576659503

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 72.464%
Totals Coverage Status
Change from base Build 12566564471: 0.0%
Covered Lines: 350
Relevant Lines: 483
💛 - Coveralls

1 similar comment
@coveralls
Copy link

coveralls commented Jan 2, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 12576659503

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 72.464%
Totals Coverage Status
Change from base Build 12566564471: 0.0%
Covered Lines: 350
Relevant Lines: 483
💛 - Coveralls

briandfoy
briandfoy approved these changes Jan 2, 2025
View reviewed changes
Copy link
Owner

@briandfoy briandfoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that argument handling is weird.

@briandfoy briandfoy merged commit 3f30c25 into briandfoy:master Jan 2, 2025
23 checks passed
@briandfoy briandfoy self-assigned this Jan 2, 2025
@briandfoy briandfoy added Type: bug an existing feature does not work Status: accepted The fix is accepted and removed Type: enhancement improve a feature that already exists Priority: low get to this whenever labels Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: diff The diff program Status: accepted The fix is accepted Type: bug an existing feature does not work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy