Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mkfifo: remove a global variable #901

Merged
merged 1 commit into from
Jan 3, 2025
Merged

mkfifo: remove a global variable #901

merged 1 commit into from
Jan 3, 2025

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Jan 3, 2025

  • Avoid calculating the default mode in the case where a numeric mode is supplied to -m (get_mode() just returns oct($opt_m) here
  • Defer default mode calculation to a function which is used for 1) no -m option and 2) symbolic permission passed to -m
  • Passing a value to umask() is not necessary because we only want to get the current value, and the mkfifo() call uses an explicit mode param

@mknos
mkfifo: remove a global variable
b4d22d4 
* Avoid calculating the default mode in the case where a numeric mode is supplied to -m (get_mode() just returns oct($opt_m) here
* Defer default mode calculation to a function which is used for 1) no -m option and 2) symbolic permission passed to -m
* Passing a value to umask() is not necessary because we only want to get the current value, and the mkfifo() call uses an explicit mode param
@mknos mknos temporarily deployed to automated_testing January 3, 2025 04:00 — with GitHub Actions Inactive
@mknos mknos had a problem deploying to automated_testing January 3, 2025 04:00 — with GitHub Actions Failure
@mknos mknos had a problem deploying to automated_testing January 3, 2025 04:00 — with GitHub Actions Failure
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: mkfifo The mkfifo program labels Jan 3, 2025
@mknos mknos temporarily deployed to automated_testing January 3, 2025 04:00 — with GitHub Actions Inactive
briandfoy
briandfoy approved these changes Jan 3, 2025
View reviewed changes
bin/mkfifo Show resolved Hide resolved
@briandfoy briandfoy merged commit 79a9162 into briandfoy:master Jan 3, 2025
3 of 22 checks passed
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Jan 3, 2025
@briandfoy briandfoy self-assigned this Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: mkfifo The mkfifo program Status: accepted The fix is accepted Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mknos @briandfoy