-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ed: better relative addresses #902
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mknos
commented
Jan 3, 2025
•
edited
Loading
edited
- The initial implementation of relative addresses was too limited
- GNU and OpenBSD ed allow repeated +n, mixed +n and --++, as well as basing address from dot, dollar or a marked address
* The initial implementation of relative addresses was too limited * GNU and OpenBSD ed allow repeated +n, mixed +n and --++, as well as basing address from dot, dollar or a marked address * tests.. ++1= invalid: ambiguous += current +1 .+= current + 1 +1= current + 1 .+1= current + 1 .+3++= current + 5: ++ follows +n $---= end - 3 $-3= end - 3 $-3+3= end: repeated +n 'x-5,'x+5nl list 5 lines of context around marked line x
github-actions
bot
added
Type: enhancement
improve a feature that already exists
Priority: low
get to this whenever
Program: ed
The ed program
labels
Jan 3, 2025
mknos
temporarily deployed
to
automated_testing
January 3, 2025 06:37 — with
GitHub Actions
Inactive
mknos
had a problem deploying
to
automated_testing
January 3, 2025 06:37 — with
GitHub Actions
Error
mknos
had a problem deploying
to
automated_testing
January 3, 2025 06:37 — with
GitHub Actions
Error
mknos
had a problem deploying
to
automated_testing
January 3, 2025 06:37 — with
GitHub Actions
Failure
mknos
had a problem deploying
to
automated_testing
January 3, 2025 06:37 — with
GitHub Actions
Error
mknos
had a problem deploying
to
automated_testing
January 3, 2025 06:37 — with
GitHub Actions
Error
mknos
had a problem deploying
to
automated_testing
January 3, 2025 06:37 — with
GitHub Actions
Failure
mknos
had a problem deploying
to
automated_testing
January 3, 2025 06:37 — with
GitHub Actions
Error
mknos
temporarily deployed
to
automated_testing
January 3, 2025 06:37 — with
GitHub Actions
Inactive
mknos
had a problem deploying
to
automated_testing
January 3, 2025 06:37 — with
GitHub Actions
Error
mknos
had a problem deploying
to
automated_testing
January 3, 2025 06:37 — with
GitHub Actions
Failure
mknos
had a problem deploying
to
automated_testing
January 3, 2025 06:37 — with
GitHub Actions
Error
mknos
had a problem deploying
to
automated_testing
January 3, 2025 06:37 — with
GitHub Actions
Error
mknos
had a problem deploying
to
automated_testing
January 3, 2025 06:38 — with
GitHub Actions
Error
mknos
had a problem deploying
to
automated_testing
January 3, 2025 06:38 — with
GitHub Actions
Error
mknos
had a problem deploying
to
automated_testing
January 3, 2025 06:38 — with
GitHub Actions
Error
mknos
had a problem deploying
to
automated_testing
January 3, 2025 06:38 — with
GitHub Actions
Error
mknos
had a problem deploying
to
automated_testing
January 3, 2025 06:38 — with
GitHub Actions
Error
mknos
had a problem deploying
to
automated_testing
January 3, 2025 06:38 — with
GitHub Actions
Error
mknos
had a problem deploying
to
automated_testing
January 3, 2025 06:38 — with
GitHub Actions
Error
briandfoy
approved these changes
Jan 3, 2025
briandfoy
added
Status: accepted
The fix is accepted
and removed
Priority: low
get to this whenever
labels
Jan 3, 2025
changes: allow repeated - and + for relative addresses, such as 3++ or $--10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Program: ed
The ed program
Status: accepted
The fix is accepted
Type: enhancement
improve a feature that already exists
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.