Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tac: exit(1) on error #903

Merged
merged 1 commit into from
Jan 4, 2025
Merged

tac: exit(1) on error #903

merged 1 commit into from
Jan 4, 2025

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Jan 4, 2025

  • When processing multiple file arguments, and one file fails to open, exit(1) after processing all arguments to indicate something went wrong
  • Found when testing against GNU tac
%echo \\0/ > exist && perl tac . .. notexist exist 
tac: '.' is a directory
tac: '..' is a directory
tac: failed to open 'notexist': No such file or directory
\0/
%echo $?
1

@mknos
tac: exit(1) on error
393837b 
* When processing multiple file arguments, and one file fails to open, exit(1) after processing all arguments to indicate something went wrong
* Found when testing against GNU tac
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: tac The tac program labels Jan 4, 2025
@mknos mknos temporarily deployed to automated_testing January 4, 2025 05:17 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 4, 2025 05:17 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 4, 2025 05:17 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 4, 2025 05:17 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 4, 2025 05:17 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 4, 2025 05:17 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 4, 2025 05:17 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 4, 2025 05:17 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 4, 2025 05:18 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 4, 2025 05:18 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 4, 2025 05:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 4, 2025 05:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 4, 2025 05:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 4, 2025 05:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 4, 2025 05:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 4, 2025 05:19 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 4, 2025 05:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 4, 2025 05:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 4, 2025 05:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 4, 2025 05:21 — with GitHub Actions Inactive
@briandfoy briandfoy merged commit e981a8b into briandfoy:master Jan 4, 2025
23 checks passed
@briandfoy
Copy link
Owner

changes: exit 1 on error

@briandfoy briandfoy self-assigned this Jan 4, 2025
@briandfoy briandfoy added the Status: accepted The fix is accepted label Jan 4, 2025
@briandfoy briandfoy removed the Priority: low get to this whenever label Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: tac The tac program Status: accepted The fix is accepted Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mknos @briandfoy