Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rm: simplify process_options() #912

Merged
merged 1 commit into from
Jan 7, 2025
Merged

rm: simplify process_options() #912

merged 1 commit into from
Jan 7, 2025

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Jan 7, 2025

  • is_recursive() is already smart enough to check both -R and -r, so manually setting $opts{R} is not required
  • As a regression test I removed some subdirectories, first using -r, then -R

@mknos
rm: simplify process_options()
93537f8 
* is_recursive() is already smart enough to check both -R and -r, so manually setting opt{"R"} is not required
* As a regression test I removed some subdirs, first using -r, then -R
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: rm The rm program labels Jan 7, 2025
@mknos mknos had a problem deploying to automated_testing January 7, 2025 04:27 — with GitHub Actions Failure
@mknos mknos had a problem deploying to automated_testing January 7, 2025 04:27 — with GitHub Actions Failure
@mknos mknos had a problem deploying to automated_testing January 7, 2025 04:27 — with GitHub Actions Failure
@mknos mknos had a problem deploying to automated_testing January 7, 2025 04:28 — with GitHub Actions Failure
@briandfoy briandfoy self-assigned this Jan 7, 2025
briandfoy
briandfoy approved these changes Jan 7, 2025
View reviewed changes
Copy link
Owner

@briandfoy briandfoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey, you finally touch something I did. :)

@briandfoy briandfoy merged commit 4b4cbeb into briandfoy:master Jan 7, 2025
1 of 22 checks passed
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Jan 7, 2025
briandfoy added a commit that referenced this pull request Jan 7, 2025
@briandfoy
rm doesn't set -R or -r when the other is set, so adjust test (#912)
96055d5
@briandfoy
Copy link
Owner

I adjusted the test for this script since it looked at the internals to see what options were set. No big whoop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: rm The rm program Status: accepted The fix is accepted Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mknos @briandfoy