Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaced all md5sum.txt with md5sum.result #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Jeltje
Copy link

@Jeltje Jeltje commented Jun 28, 2017

This makes the Docker image compatible with the GA4GH workflow examples, which expect <tool>.result instead of <tool>.txt

Did a test run

dockstore tool launch --local-entry Dockstore.cwl --json test.dockstore.json

using a local build with the updated Docker image (and the dockerPull line in Dockstore.cwl replaced with the test image) to verify this runs.

@Jeltje
Copy link
Author

Jeltje commented Jun 28, 2017

I believe the check fails because the system builds docker build -t quay.io/briandoconnor/dockstore-tool-md5sum but then pulls quay.io/briandoconnor/dockstore-tool-md5sum:1.0.3 from quay.io because that build is specified in the cwl file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant