[pmemkv] Add PmemKV client using pmemkv's Java API. #1545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping, is there a chance for a quick review in your spare time, please? 😺 @busbey? |
lukaszstolarczuk
force-pushed
the
add-pmemkv-module
branch
from
b0111cc to
391ba30
Compare
pmemkv is a local/embedded key-value datastore optimized for persistent memory (https://github.com/pmem/pmemkv-java).
lukaszstolarczuk
force-pushed
the
add-pmemkv-module
branch
from
391ba30 to
a665315
Compare
|
We've updated the PR with the extra params using the latest pmemkv-java release (1.2.0) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pmemkv is a local/embedded key-value datastore optimized
for persistent memory (https://github.com/pmem/pmemkv-java).
// Rationale:
We've prepared a new module for pmemkv(-java) datastore and we've successfully gathered some data using this module. We believe it may be useful for potential pmemkv users to test it on their own.
// Known caveats:
There's still a tiny issue, we couldn't overcome and we were hoping you can help us solve it.
Please see: pmem#3
Maybe we're missing something obvious.
// Checks:
FYI, we've enabled GHA CI build for our module, on our fork and it seems to compile just fine