Script and variable clean up.

- Remove hubot-scripts package (it was breaking startup)
- More defaults cleanup
- Fix contributors page
- Clean up custom scripts - with hubot_custom_scripts == true all scripts in
  files/scripts will be installed as well

CHANGELOG.md

@@ -173,3 +173,11 @@
 - Remove all scripts which do not have packaged versions
 - Remove deprecated hubot-scripts.json functionality and variables
 - Update documentation
+
+## v1.7.1
+
+- Remove hubot-scripts package (it was breaking startup)
+- More defaults cleanup
+- Fix contributors page
+- Clean up custom scripts - with hubot_custom_scripts == true all scripts in
+  files/scripts will be installed as well

CONTRIBUTORS.md

@@ -3,9 +3,9 @@
 ```
  ________ _____   _  ____ ______  __
 /_  __/ // / _ | / |/ / //_/ __/ / /
- / / / _  / __ |/    / ,< _\ \  /_/ 
+ / / / _  / __ |/    / ,< _\ \  /_/
 /_/ /_//_/_/ |_/_/|_/_/|_/___/ (_)
-`
+```
 
 Much thanks to these fine folks for contributing to the role:
 

defaults/main.yml

@@ -85,7 +85,6 @@ hubot_node_packages:
   - hubot-calculator
   - hubot-{{ hubot_adapter }}
   - hubot-redis-brain
-  - hubot-scripts
   - hubot-xkcd
   - hubot-youtube
   - lodash
@@ -110,21 +109,21 @@ hubot_external_scripts:
 
 #############################################################################
 #
-# hubot_external_git_scripts: A list of additional Hubot scripts to checkout 
-# from git.
+# hubot_custom_scripts: Boolean — Install all scripts from files/scripts
 #
 #############################################################################
-#
-# hubot_external_git_scripts:
-#   - { name: hubot-jenkins-userauth, repo_url: "https://github.com/joestewart/hubot-jenkins-userauth.git" }
-#
+
+hubot_custom_scripts: false
+
 #############################################################################
 #
-# hubot_custom_scripts: A list of custom additional Hubot scripts in the
-# files/scripts directory to use.
-#
+# hubot_external_git_scripts: A list of additional Hubot scripts to
+#                             check out from git repositories
 #############################################################################
 
+# hubot_external_git_scripts:
+#   - { name: hubot-jenkins-userauth, repo_url: "https://github.com/joestewart/hubot-jenkins-userauth.git" }
+
 # EPEL repository URL
 epel_repo_url: "https://dl.fedoraproject.org/pub/epel/epel-release-latest-{{ ansible_distribution_major_version }}.noarch.rpm"
 

tasks/main.yml

@@ -94,7 +94,7 @@
     owner: "{{ hubot_admin }}"
     mode: "0644"
   with_items: hubot_custom_scripts
-  when: hubot_custom_scripts is defined
+  when: hubot_custom_scripts == "true"
   notify:
     - restart hubot
   tags:
@@ -110,16 +110,6 @@
   tags:
     - hubot_scripts
 
-- name: Install hubot git scripts
-  become: False
-  git: "repo={{ item.repo_url }} version={{ item.version | default('master') }} dest={{ hubot_dir }}/scripts/{{ item.name }}"
-  with_items: hubot_git_scripts
-  when: hubot_git_scripts is defined
-  notify:
-    - restart hubot
-  tags:
-    - hubot_scripts
-
 - name: Configure Hubot external scripts
   become: True
   become_user: root

version.txt

@@ -1 +1 @@
-v1.7.0
+v1.7.1