Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chart rotation potentially incorrect very near celestial poles #117

Open
brickbots opened this issue Nov 29, 2023 · 1 comment
Open

Chart rotation potentially incorrect very near celestial poles #117

brickbots opened this issue Nov 29, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@brickbots
Copy link
Owner

When aligned on a pixel off-center from the camera image, the chart rotation appears incorrect when the celestial pole is between the geometric center of the camera image and the target pixel.

Tetra3 returns roll based on the geometric center, not the target pixel. According to Gustav this would be tricky to implement.

A potential solution is to render the chart based on the geometric center of the camera image (raw solution values + roll) then offset this render by the target pixel values to align it with the target pixel before copying it to the screen and adding the reticle. This would ultimately center the chart on the target pixel, but provide a more stable rotation reference.

@brickbots brickbots added the bug Something isn't working label Mar 17, 2024
@TakKanekoGit
Copy link
Contributor

@brickbots -- I will try to pick this issue up in step 2 of the "Roll Issue Fix".

As I understand from your comments above, the roll measured by plate solving is only valid at the centre of the camera FoV. The difference between the roll at the camera centre and the target pixel becomes bigger higher declinations. If we want to use the roll as a measurement, as proposed for later enhancements, I think we need to fix this?

Here's how I propose to fix it:

  1. Take the (ra_camera, dec_camera, roll_camera) from plate solving. Compare the measured roll against the roll calculated at (ra_camera, dec_camera) against the measured roll_camera to get the roll_offset. This should be reasonably constant for an Alt/Az mount.
  2. Work out the (ra_scope, dec_scope) at the target pixel as done currently. Calculate the roll at the target and add the roll_offset. This should give the correct roll as seen by the scope.

Do you think this will work or is there more to the problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants