Compensate for roll offset (rebased) #192 #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
August 16, 2024 21:29
…solved["Roll"] = None (roll at the target), which needs to be calculated in integrator.py (cherry picked from commit 623c504)
… roll at the target RA/Dec. (cherry picked from commit edcc6cc)
(cherry picked from commit 084a863)
…d["Roll_offset"] (cherry picked from commit 9f5e752)
(cherry picked from commit 0201113)
…ve to the celestial pole? (cherry picked from commit ee95d75)
(cherry picked from commit 8fd3c59)
(cherry picked from commit 5c4bb0b)
(cherry picked from commit 3d5fdf4)
(cherry picked from commit b9f4fb1)
(cherry picked from commit b370fcb)
(cherry picked from commit 4f959e8)
|
Just tested this under the stars and it works FANTASTIC! The estimate roll seems to match very, very closely and it provides a really nice experience when using the chart. Thank you @TakKanekoGit for this great contribution 💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compensates for the roll offset between the roll seen by the camera and the expected roll at the (RA, Dec). This should also fix issue #117.
The roll at the camera center is different from the roll at the target pixel. To address this, the (RA, Dec, Roll) at the camera center get stored as solution["RA_camera"], solution["Dec_camera"] and solution["Roll_camera"]. The coordinates at the target pixels are still the same: solution["RA"], etc.
The roll offset is calculated at the camera center in integrator.py and stored as solution["Roll_offset"] every plate solve. solution["Roll"] at the target is calculated from the expected roll at the target (RA, Dec) and compensated with the Roll_offset.
This should display the constellation with the correct roll as seen by an observer. This PR hasn't been system-tested on a PiFinder or field-tested. It's possible that the sign for the roll_offset is the wrong way round. If so, this can be changed in integrator.estimate_roll_offset().