Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp the minitesting bundled configuration so it uses Rack::Test #954

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

jaredcwhite
Copy link
Member

@jaredcwhite jaredcwhite commented Dec 8, 2024

At this juncture, I'd say it really makes the most sense to do automated testing at the Rack level so you can test both static routes (post site build) and dynamic routes, all via the Roda server application under the hood.

This PR updates the minitesting bundled configuration, as well as adds a canonical boot sequence and Minitest-based Bridgetown::Test superclass that test files can subclass. I'm backing out of "shoulda" etc. in favor of standard test definitions, and the old Rails DOM Assertions stuff is gone entirely in favor of Nokolexbor, mirroring how the HTML Inspectors feature works. I think this is much cleaner overall, and provides for really nice static+dynamic test ergonomics.

We'll eventually want to double-check this works nicely with the Bridgetown Sequel gem as well.

Resolves #570

Addendum: I also added support for Minitest expectations to Bridgetown tests — that's the syntax where you can say expect([1,2,3]).must_include(2). I'm starting to like that more than assert_ now that I've been spending time with it. In fact, I went a step further with some custom extensions so you can write "intuitive" expectations like expect(something) == "to equal this". Whoa!

  • Add docs for the expectations to Testing page

As part of these changes, I removed the RSpec Mocks library and replaced with Minitest mocks and stubs.

Update 2: Well, this has become quite the rabbit hole. I ended up extending the Spec DSL fully into the base test classes, allowing the use of describe, before/after, and it. This effectively lets us migrate away from the "shoulda" gem, because context, setup and should essentially map 1:1 with the Spec DSL. Once we transition, we can remove the shoulda gem dependency entirely and rely on "vanilla" Minitest functionality. 😎

Sorry, something went wrong.

radanskoric added a commit to radanskoric/masterhotwire that referenced this pull request Dec 16, 2024
It supports testing static pages and Roda routes with
the same setup.

I extracted it from bridgetownrb/bridgetown#954
With Jared's advice he gave me in Discord.
- also add  "intuitive" expectations like `expect(something) == "to equal this"`
- remove RSpec Mocks library and replace with Minitest mocks and stubs
@jaredcwhite
Copy link
Member Author

Ooo, this is worth looking into:

https://github.com/kematzy/minitest-rack

transition some "shoulda" style tests to Minitest spec syntax
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: support Roda routes testing within the minitest configuration
1 participant