Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zed manage: Add vector support #4757

Merged
merged 1 commit into from
Sep 5, 2023
Merged

zed manage: Add vector support #4757

merged 1 commit into from
Sep 5, 2023

Conversation

mattnibs
Copy link
Collaborator

Add vector support to lake manger so that vectors are created for objects that do not have any.

@mattnibs mattnibs requested a review from a team August 29, 2023 21:41
@mattnibs mattnibs removed the request for review from a team August 29, 2023 21:50
@mattnibs mattnibs marked this pull request as draft August 29, 2023 21:50
@mattnibs mattnibs marked this pull request as ready for review August 30, 2023 19:49
@mattnibs mattnibs requested a review from a team August 30, 2023 19:49
cmd/zed/manage/lakemanage/branch.go Outdated Show resolved Hide resolved
cmd/zed/manage/lakemanage/lakemanage.go Outdated Show resolved Hide resolved
Comment on lines 20 to 21
// scan recieves a sorted stream of objects and sends to ch a series
// of Runs that are good candidates for compaction.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't accurate.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed it

@mattnibs mattnibs force-pushed the manage-vectors branch 2 times, most recently from 2131af4 to 12e9821 Compare September 5, 2023 21:24
Base automatically changed from compact-vectors to main September 5, 2023 21:29
Add vector support to lake manger so that vectors are created for
objects that do not have any.
@mattnibs mattnibs merged commit ff09585 into main Sep 5, 2023
3 checks passed
@mattnibs mattnibs deleted the manage-vectors branch September 5, 2023 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants