vector: Rudimentary function support #5222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds rudimentary support for functions. There are a lot of shortcomings compared to sequence notably: only supports function lower(), does not variants/unions and wrapped errors are not handled, and it is not currently tested. Future work will brings things in feature parity.
mattnibs
changed the title
mccanne
reviewed
Aug 20, 2024
| return vector.NewStringError(t.zctx, "lower: string arg required", v.Len()) | ||
| } | ||
| out := vector.NewStringEmpty(v.Len(), vector.NewBoolEmpty(v.Len(), nil)) | ||
| for i := uint32(0); i < v.Len(); i++ { |
There was a problem hiding this comment.
I think we want a pattern where there is a string function applied to string/const/dict/view and you get back a vector.Any. So instead of looping over slots you apply a function to a vector and get a vector back. So you would pass the go func strings.ToLower to the apply function and get back the vector. We would have to make an applier for every possible type signature but that seems reasonable since it's linear in problem size.
mccanne
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds rudimentary support for functions. There are a lot of shortcomings compared to sequence notably: only supports function lower(), does not variants/unions and wrapped errors are not handled, and it is not currently tested. Future work will brings things in feature parity.