Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vam: Add collect aggregation #5586

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

vam: Add collect aggregation #5586

wants to merge 1 commit into from
+97 −31

Conversation

mattnibs
Copy link
Collaborator

No description provided.

@mattnibs mattnibs requested a review from a team January 18, 2025 00:45
@mattnibs
Copy link
Collaborator Author

This implementation does not keep the in-order behavior that the sequential collect version does (i.e., the resultant array is in order from which values were received). I do not think it would be easy to have this behavior without completely rewriting how we do aggregations writ large.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mattnibs