Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OpenTelemetry runtime and shutdown #142

Merged
merged 1 commit into from
Dec 1, 2024
Merged

Conversation

kylewlacy
Copy link
Member

This PR fixes some issues around OpenTelemetry following #140: namely, trying to use BRIOCHE_ENABLE_OTEL=1 would cause a deadlock, and even after fixing that, events wouldn't be flushed properly. There were two fixes involved:

  1. Enable Tokio batched OpenTelemetry exporter. This fixes a panic that was silently being ignored, caused by some HTTP code trying to access the Tokio runtime on a non-Tokio thread
  2. Update OpenTelemetry shutdown code. opentelemetry::global::shutdown_tracer_provider() no longer seems to do it. Now, we explicitly shut down the tracer provider directly.

@kylewlacy kylewlacy merged commit 0a797f6 into main Dec 1, 2024
5 checks passed
@kylewlacy kylewlacy deleted the fix-opentelemetry-shutdown branch December 1, 2024 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant