Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add frame to process events after writing description #144

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

kylewlacy
Copy link
Member

This is a small PR that updates the process events writer (see #138) so the process description is split into a new frame and flushed immediately, even before the process runs.

The main motivation here is, if you see an events.bin.zst file on disk, you should be able to inspect it to see which process it's for right away without waiting for it to hit a frame size of 1MB.

@kylewlacy kylewlacy merged commit dd806e4 into main Dec 2, 2024
5 checks passed
@kylewlacy kylewlacy deleted the split-process-events-frame branch December 2, 2024 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant