Prior calculation performance for 1000+ mutations #71
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had some issues with this for large samples, but since we first wrote the software there's been a new approximation for logstirling coefficients developed:
I have adapted this to the prior calculation, and fixed the docker build file to test.
For ~1000 mutations, takes the prior calculation from nearly a minute to almost instant, with minor error:
For 10,000 mutations, the old calculation took 20 minutes, and now it takes seconds.
There is no difference in clustering results between the versions.