Add function agg_by_strata, which is a generalized version of the compute_freq_by_strata
#659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rearrange and enforce adj_group and group_membership being on the sam…
jkgoodrich
changed the title
agg_by_strata and use in compute_freq_by_strataagg_by_strata, which is a generalized version of the compute_freq_by_strata.
jkgoodrich
changed the title
agg_by_strata, which is a generalized version of the compute_freq_by_strata.agg_by_strata, which is a generalized version of the compute_freq_by_strata
jkgoodrich
commented
Jan 16, 2024
mike-w-wilson
approved these changes
Jan 17, 2024
There was a problem hiding this comment.
One last thing that confused me at first -- the adj_group annotation originally made me think of a single adj group, the gnomAD adj group, index 0. I understand it is the group of groups with adj but changing this variable to adj_groups is a bit more intuitive since we are referencing the groups that are adj. Then LGTM!
Co-authored-by: Mike Wilson <[email protected]>
Co-authored-by: Mike Wilson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also,
Modify
compute_freq_by_stratato useagg_by_strata