Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up compute_coverage_stats, change it to use agg_by_strata and have an optional group_membership_ht parameter #660

Merged
merged 8 commits into from
Jan 17, 2024
Merged

Clean up compute_coverage_stats, change it to use agg_by_strata and have an optional group_membership_ht parameter #660

merged 8 commits into from
Jan 17, 2024

Conversation

jkgoodrich
Copy link
Contributor

@jkgoodrich jkgoodrich changed the base branch from main to jg/agg_by_strata January 10, 2024 21:08
@jkgoodrich jkgoodrich mentioned this pull request Jan 11, 2024
Closed
Base automatically changed from jg/agg_by_strata to main January 17, 2024 17:51
@jkgoodrich jkgoodrich changed the title Clean up compute_coverage_stats and change to use agg_by_strata and have an optional group_membership_ht parameter Clean up compute_coverage_stats, change it to use agg_by_strata and have an optional group_membership_ht parameter Jan 17, 2024
mike-w-wilson
mike-w-wilson approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@mike-w-wilson mike-w-wilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another reorg at the top similar to the last review but smaller and I could do it in here rather than a PR. Other than that, this looks good considering the follow up PRs.

gnomad/utils/sparse_mt.py Outdated Show resolved Hide resolved
gnomad/utils/sparse_mt.py Outdated Show resolved Hide resolved
gnomad/utils/sparse_mt.py Outdated Show resolved Hide resolved
gnomad/utils/sparse_mt.py Outdated Show resolved Hide resolved
gnomad/utils/sparse_mt.py Outdated Show resolved Hide resolved
gnomad/utils/sparse_mt.py Outdated Show resolved Hide resolved
gnomad/utils/sparse_mt.py Outdated Show resolved Hide resolved
@jkgoodrich jkgoodrich merged commit 94dc3ff into main Jan 17, 2024
3 checks passed
@jkgoodrich jkgoodrich deleted the jg/clean_up_coverage_code branch January 17, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mike-w-wilson mike-w-wilson mike-w-wilson approved these changes

Assignees

@mike-w-wilson mike-w-wilson

@jkgoodrich jkgoodrich

Labels
Changelog: new feature Coverage v4.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkgoodrich @mike-w-wilson