Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter to Gencode CDS by genes and by exon paddings #747

Merged
merged 14 commits into from
Dec 20, 2024
Merged

Filter to Gencode CDS by genes and by exon paddings #747

merged 14 commits into from
Dec 20, 2024

Conversation

KoalaQin
Copy link
Contributor

This will filter the Gencode CDS further optionally by genes and by adding a padding.

@KoalaQin KoalaQin requested a review from jkgoodrich December 19, 2024 21:15
jkgoodrich
jkgoodrich requested changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@jkgoodrich jkgoodrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few thoughts. Also, can you undo the changes to the init_scripts? That can get fixed in a different PR, but I don't think it really belongs in this one

gnomad/utils/filtering.py Outdated Show resolved Hide resolved
gnomad/utils/filtering.py Outdated Show resolved Hide resolved
gnomad/utils/filtering.py Outdated Show resolved Hide resolved
gnomad/utils/filtering.py Outdated Show resolved Hide resolved
gnomad/utils/filtering.py Outdated Show resolved Hide resolved
@KoalaQin
Copy link
Contributor Author

These init_scripts were changed by my pre-commit, fix end of files, it will be done even when I undo it when I commit again. What do I do?

@jkgoodrich
Copy link
Contributor

You should be able to disable the pre-commit hook. But also, I think it's only supposed to run on the files that have been modified in the current branch

@KoalaQin
Copy link
Contributor Author

KoalaQin commented Dec 20, 2024 •
edited
Loading

I used --no-verify to my commit to disable the precommit, but it's still like this for 2 files

jkgoodrich
jkgoodrich requested changes Dec 20, 2024
View reviewed changes
gnomad/utils/filtering.py Outdated Show resolved Hide resolved
gnomad/utils/filtering.py Outdated Show resolved Hide resolved
gnomad/utils/filtering.py Outdated Show resolved Hide resolved
gnomad/utils/filtering.py Outdated Show resolved Hide resolved
gnomad/utils/filtering.py Outdated Show resolved Hide resolved
gnomad/utils/filtering.py Outdated Show resolved Hide resolved
gnomad/utils/filtering.py Outdated Show resolved Hide resolved
gnomad/utils/filtering.py Outdated Show resolved Hide resolved
gnomad/utils/filtering.py Outdated Show resolved Hide resolved
gnomad/utils/filtering.py Outdated Show resolved Hide resolved
KoalaQin and others added 2 commits December 20, 2024 15:50
@KoalaQin KoalaQin requested a review from jkgoodrich December 20, 2024 20:58
jkgoodrich
jkgoodrich approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@jkgoodrich jkgoodrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two small things, but then lgtm!

gnomad/utils/filtering.py Outdated Show resolved Hide resolved
gnomad/utils/filtering.py Outdated Show resolved Hide resolved
@KoalaQin KoalaQin merged commit e7fc859 into main Dec 20, 2024
5 checks passed
@KoalaQin KoalaQin deleted the qh/filter_cds branch December 20, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkgoodrich jkgoodrich jkgoodrich approved these changes

Assignees

@jkgoodrich jkgoodrich

@KoalaQin KoalaQin

Labels
Changelog: new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KoalaQin @jkgoodrich