Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grpmax vs European AF split nonsynonymous variant analysis #597
grpmax vs European AF split nonsynonymous variant analysis #597
Changes from 3 commits
ee3f983
2d1494c
766d541
398f282
cef0eba
622ddc4
2389ca9
d4ccfa5
63dae9d
f572821
403df5f
093f774
b3f4b28
60c0510
2fc6627
466c25a
8ff42ee
c831c42
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some print statements to check these filters:
The proportion of variants retained in v2 is much higher, which makes me wonder: is there something off about the
most_severe_consequence
field in the v4 HT? Maybe a helpful debugging step is to rerun after filtering v4 to MANE/canonical transcripts only and v2 to canonical only?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you need this twice?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sadly yes because the filter above changes the table so the expr assignment in L108 and L110 points to the old table and breaks hail. There may be another way that my Friday brain isnt thinking of though...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh yeah I totally forgot -- good call. I guess the alternative is probably something like
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes -- this is better