[JN-1600] customer-specific mixpanel export #1443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorlbark
approved these changes
Feb 3, 2025
| delivery.addMessage(mixpanelEvent); | ||
| String eventDomain = getEventCurrentDomain(event); |
There was a problem hiding this comment.
Why not send the portal shortcode when tracking to avoid domain matching?
There was a problem hiding this comment.
I suppose we could send portal shortcode and environment (we'd need the environment to not log sandbox events to their mixpanel)
| <div> | ||
| <label className="form-label mt-2"> | ||
| Mixpanel api token <InfoPopup content={<span> | ||
| If provided, events for participant interactions with the website will |
There was a problem hiding this comment.
should we specify that the events contain no identifiable information?
MatthewBemis
approved these changes
Feb 3, 2025
| import java.util.Map; | ||
|
|
||
| /** | ||
| * we don't want to have to go to the database every time an event is logged in our system to get the configs, |
There was a problem hiding this comment.
great decision to cache this
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION (include screenshots, and mobile screenshots for participant UX)
This adds a mixpanel token to portal environment configs. If set, and a custom domain is present, events in that domain will also be logged to the given token.
This also adds spring caching so that we don't have to load and assemble the config map every time an event is called. this is probably overkill for our purposes, but I thought it was a good excuse to dip our toes into using spring caching. Down the road, I could imagine us implementing a simple postgres-backed Spring cache manager so that we wouldn't have to do crude cache evictions based on timeouts.
TO TEST: (simple manual steps for confirming core behavior -- used for pre-release checks)
This is tricky to test in dev...