Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding batch 2 data #58

Merged
merged 4 commits into from
Mar 9, 2021
Merged

Adding batch 2 data #58

merged 4 commits into from
Mar 9, 2021

Conversation

gwaybio
Copy link
Member

@gwaybio gwaybio commented Feb 22, 2021

The pipeline is slightly hacky (the recipe would fix this) but the profiles are now harmonized to the same pycytominer pipeline as batch 1 data. I add profiles, metadata, and cell counts in this PR.

@gwaybio
Copy link
Member Author

gwaybio commented Feb 22, 2021

I have not yet checked if the pipeline processed all plates as described in #57 (comment), but the pipeline did not throw any errors.

@gwaybio gwaybio requested a review from shntnu February 22, 2021 18:07
Copy link
Collaborator

@shntnu shntnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth adding consensus as well, to achieve the immediate goals of getting the paper out?
If so I can prioritize #48 (comment) and merge that and then you create consensus here.
If not, you are all set here (approved)

@gwaybio
Copy link
Member Author

gwaybio commented Mar 8, 2021

let's do this in three pull requests

  1. Merge batch 2 profiles
  2. Merge Feature selected files available, with more row annotations included #48
  3. Add batch 2 consensus signatures in a separate PR

@shntnu - will you be able to get to #48 this week?

@shntnu
Copy link
Collaborator

shntnu commented Mar 9, 2021

@shntnu - will you be able to get to #48 this week?

Miraculously, yes; done.

@gwaybio gwaybio merged commit 0d52652 into broadinstitute:master Mar 9, 2021
@gwaybio gwaybio deleted the add-batch2 branch March 9, 2021 20:59
@gwaybio gwaybio mentioned this pull request Mar 19, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants