Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding cell quality scoring using the Feldman et al. method to recipe #65

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

gwaybio
Copy link
Member

@gwaybio gwaybio commented Mar 25, 2021

From Feldman et al. 2019:

Adding data per site to capture Figure 2D, and adding a cell quality metric to filter cells as performed in Figure 2E.

Currently, the filtering method is not exactly as Figure 2E. We filter cells that have more than 1 different perfectly matching barcode.

@gwaybio gwaybio marked this pull request as ready for review May 12, 2021 19:15
@gwaybio gwaybio changed the title Adding metrics from Feldman et al. to recipe Adding cell quality scoring using the Feldman et al. method to recipe May 12, 2021
@gwaybio
Copy link
Member Author

gwaybio commented May 13, 2021

Another TODO

Add barcode_col argument to

crispr_barcode_gene_df = cell_quality.assign_cell_quality(
count_df=crispr_barcode_gene_df,
parent_cols=spot_parent_cols,
score_col=spot_score_cols[0],
).assign(

Only the Feldman method uses this argument, it defaults to None, but it needs to be specified. Figure out what to specify barcode_col as if any other method besides Feldman is used. Maybe it is harmless to add the Feldman barcode_col to every assign_cell_quality() arg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant