Skip to content

Commit

Permalink
test scalafix
Browse files Browse the repository at this point in the history
  • Loading branch information
cjllanwarne committed Dec 12, 2023
1 parent c844ff7 commit c48d79b
Show file tree
Hide file tree
Showing 11 changed files with 93 additions and 16 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import akka.http.scaladsl.model.headers.OAuth2BearerToken
import akka.testkit.TestKit
import org.broadinstitute.dsde.rawls.model.UserInfo
import org.mockito.ArgumentMatchers.any
import org.mockito.Mockito.{RETURNS_SMART_NULLS, doReturn, spy, when}
import org.mockito.Mockito.{doReturn, spy, when, RETURNS_SMART_NULLS}
import org.scalatest.flatspec.AnyFlatSpecLike

import scala.concurrent.{Await, ExecutionContext, ExecutionContextExecutor, Future}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,12 @@ import com.typesafe.scalalogging.LazyLogging
import nl.grons.metrics4.scala.{Counter, DefaultInstrumented, MetricName}
import org.broadinstitute.dsde.rawls.TestExecutionContext
import org.broadinstitute.dsde.rawls.config.WDLParserConfig
import org.broadinstitute.dsde.rawls.dataaccess.MockCromwellSwaggerClient.{makeToolInputParameter, makeToolOutputParameter, makeValueType, makeWorkflowDescription}
import org.broadinstitute.dsde.rawls.dataaccess.MockCromwellSwaggerClient.{
makeToolInputParameter,
makeToolOutputParameter,
makeValueType,
makeWorkflowDescription
}
import slick.basic.DatabaseConfig
import slick.jdbc.JdbcProfile
import slick.jdbc.MySQLProfile.api._
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,11 @@ import org.broadinstitute.dsde.rawls.dataaccess.MockBigQueryServiceFactory
import org.broadinstitute.dsde.rawls.dataaccess.MockBigQueryServiceFactory.{createKeyList, createTestTableResult}
import org.broadinstitute.dsde.rawls.dataaccess.slick.TestDriverComponent
import org.broadinstitute.dsde.rawls.entities.EntityRequestArguments
import org.broadinstitute.dsde.rawls.entities.exceptions.{DataEntityException, EntityTypeNotFoundException, UnsupportedEntityOperationException}
import org.broadinstitute.dsde.rawls.entities.exceptions.{
DataEntityException,
EntityTypeNotFoundException,
UnsupportedEntityOperationException
}
import org.broadinstitute.dsde.rawls.model._
import org.scalatest.flatspec.AsyncFlatSpec
import org.scalatest.matchers.should.Matchers
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,27 @@ import org.broadinstitute.dsde.rawls.entities.EntityRequestArguments
import org.broadinstitute.dsde.rawls.entities.base.ExpressionEvaluationContext
import org.broadinstitute.dsde.rawls.entities.base.ExpressionEvaluationSupport.ExpressionAndResult
import org.broadinstitute.dsde.rawls.entities.datarepo.DataRepoBigQuerySupport._
import org.broadinstitute.dsde.rawls.entities.exceptions.{DataEntityException, EntityNotFoundException, EntityTypeNotFoundException}
import org.broadinstitute.dsde.rawls.entities.exceptions.{
DataEntityException,
EntityNotFoundException,
EntityTypeNotFoundException
}
import org.broadinstitute.dsde.rawls.expressions.parser.antlr.ParsedEntityLookupExpression
import org.broadinstitute.dsde.rawls.jobexec.MethodConfigResolver.{GatherInputsResult, MethodInput}
import org.broadinstitute.dsde.rawls.model.{AttributeBoolean, AttributeName, AttributeNumber, AttributeString, AttributeValue, AttributeValueRawJson, DataReferenceName, Entity, EntityTypeMetadata, GoogleProjectId, SubmissionValidationEntityInputs, SubmissionValidationValue}
import org.broadinstitute.dsde.rawls.model.{
AttributeBoolean,
AttributeName,
AttributeNumber,
AttributeString,
AttributeValue,
AttributeValueRawJson,
DataReferenceName,
Entity,
EntityTypeMetadata,
GoogleProjectId,
SubmissionValidationEntityInputs,
SubmissionValidationValue
}
import org.broadinstitute.dsde.rawls.{RawlsExceptionWithErrorReport, TestExecutionContext}
import org.mockserver.integration.ClientAndServer.startClientAndServer
import org.mockserver.model.Header
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,12 @@ import org.broadinstitute.dsde.rawls.serviceperimeter.ServicePerimeterService
import org.broadinstitute.dsde.rawls.user.UserService
import org.broadinstitute.dsde.rawls.util.MockitoTestUtils
import org.broadinstitute.dsde.rawls.webservice._
import org.broadinstitute.dsde.rawls.workspace.{MultiCloudWorkspaceAclManager, MultiCloudWorkspaceService, RawlsWorkspaceAclManager, WorkspaceService}
import org.broadinstitute.dsde.rawls.workspace.{
MultiCloudWorkspaceAclManager,
MultiCloudWorkspaceService,
RawlsWorkspaceAclManager,
WorkspaceService
}
import org.broadinstitute.dsde.workbench.dataaccess.{NotificationDAO, PubSubNotificationDAO}
import org.broadinstitute.dsde.workbench.google.mock.{MockGoogleBigQueryDAO, MockGoogleIamDAO, MockGoogleStorageDAO}
import org.broadinstitute.dsde.workbench.model.WorkbenchEmail
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,12 @@ import org.broadinstitute.dsde.rawls.user.UserService
import org.broadinstitute.dsde.rawls.util.MockitoTestUtils
import org.broadinstitute.dsde.rawls.webservice._
import org.broadinstitute.dsde.rawls.workspace.WorkspaceService.BUCKET_GET_PERMISSION
import org.broadinstitute.dsde.rawls.workspace.{MultiCloudWorkspaceAclManager, MultiCloudWorkspaceService, RawlsWorkspaceAclManager, WorkspaceService}
import org.broadinstitute.dsde.rawls.workspace.{
MultiCloudWorkspaceAclManager,
MultiCloudWorkspaceService,
RawlsWorkspaceAclManager,
WorkspaceService
}
import org.broadinstitute.dsde.rawls.{RawlsException, RawlsExceptionWithErrorReport, RawlsTestUtils}
import org.broadinstitute.dsde.workbench.dataaccess.{NotificationDAO, PubSubNotificationDAO}
import org.broadinstitute.dsde.workbench.google.HttpGoogleIamDAO.toProjectPolicy
Expand All @@ -49,7 +54,7 @@ import org.scalatest.prop.TableDrivenPropertyChecks
import org.scalatest.{BeforeAndAfterAll, OneInstancePerTest, OptionValues}

import java.sql.Timestamp
import java.time.{LocalDateTime, OffsetDateTime, ZoneOffset, Duration => JavaDuration}
import java.time.{Duration => JavaDuration, LocalDateTime, OffsetDateTime, ZoneOffset}
import java.util.UUID
import java.util.concurrent.TimeUnit
import scala.collection.JavaConverters._
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,11 @@ import org.broadinstitute.dsde.rawls.resourcebuffer.ResourceBufferService
import org.broadinstitute.dsde.rawls.serviceperimeter.ServicePerimeterService
import org.broadinstitute.dsde.rawls.user.UserService
import org.broadinstitute.dsde.rawls.util.MockitoTestUtils
import org.broadinstitute.dsde.rawls.workspace.{MultiCloudWorkspaceAclManager, RawlsWorkspaceAclManager, WorkspaceService}
import org.broadinstitute.dsde.rawls.workspace.{
MultiCloudWorkspaceAclManager,
RawlsWorkspaceAclManager,
WorkspaceService
}
import org.broadinstitute.dsde.rawls.{RawlsException, RawlsExceptionWithErrorReport, RawlsTestUtils}
import org.broadinstitute.dsde.workbench.dataaccess.{NotificationDAO, PubSubNotificationDAO}
import org.broadinstitute.dsde.workbench.google.mock.{MockGoogleBigQueryDAO, MockGoogleIamDAO, MockGoogleStorageDAO}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,12 @@ import org.broadinstitute.dsde.rawls.monitor.migration.MigrationUtils.Implicits.
import org.broadinstitute.dsde.rawls.monitor.migration.MigrationUtils.Outcome
import org.broadinstitute.dsde.rawls.monitor.migration.MigrationUtils.Outcome._
import org.broadinstitute.dsde.rawls.monitor.migration.MultiregionalBucketMigrationActor._
import org.broadinstitute.dsde.rawls.monitor.migration.{MultiregionalBucketMigration, MultiregionalBucketMigrationFailureModes, MultiregionalBucketMigrationStep, MultiregionalStorageTransferJob}
import org.broadinstitute.dsde.rawls.monitor.migration.{
MultiregionalBucketMigration,
MultiregionalBucketMigrationFailureModes,
MultiregionalBucketMigrationStep,
MultiregionalStorageTransferJob
}
import org.broadinstitute.dsde.rawls.workspace.WorkspaceServiceSpec
import org.broadinstitute.dsde.workbench.RetryConfig
import org.broadinstitute.dsde.workbench.google.mock.MockGoogleIamDAO
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,13 @@ import cats.effect.IO
import com.typesafe.config.ConfigFactory
import com.typesafe.scalalogging.LazyLogging
import org.broadinstitute.dsde.rawls.RawlsTestUtils
import org.broadinstitute.dsde.rawls.billing.{BillingProfileManagerDAO, BillingProjectOrchestrator, BillingRepository, BpmBillingProjectLifecycle, GoogleBillingProjectLifecycle}
import org.broadinstitute.dsde.rawls.billing.{
BillingProfileManagerDAO,
BillingProjectOrchestrator,
BillingRepository,
BpmBillingProjectLifecycle,
GoogleBillingProjectLifecycle
}
import org.broadinstitute.dsde.rawls.bucketMigration.BucketMigrationService
import org.broadinstitute.dsde.rawls.config._
import org.broadinstitute.dsde.rawls.coordination.UncoordinatedDataSourceAccess
Expand All @@ -30,7 +36,14 @@ import org.broadinstitute.dsde.rawls.google.MockGooglePubSubDAO
import org.broadinstitute.dsde.rawls.jobexec.{SubmissionMonitorConfig, SubmissionSupervisor}
import org.broadinstitute.dsde.rawls.metrics.{InstrumentationDirectives, RawlsInstrumented, RawlsStatsDTestUtils}
import org.broadinstitute.dsde.rawls.mock._
import org.broadinstitute.dsde.rawls.model.{Agora, ApplicationVersion, Dockstore, RawlsBillingAccountName, RawlsRequestContext, RawlsUser}
import org.broadinstitute.dsde.rawls.model.{
Agora,
ApplicationVersion,
Dockstore,
RawlsBillingAccountName,
RawlsRequestContext,
RawlsUser
}
import org.broadinstitute.dsde.rawls.monitor.HealthMonitor
import org.broadinstitute.dsde.rawls.resourcebuffer.ResourceBufferService
import org.broadinstitute.dsde.rawls.serviceperimeter.ServicePerimeterService
Expand All @@ -39,7 +52,12 @@ import org.broadinstitute.dsde.rawls.spendreporting.SpendReportingService
import org.broadinstitute.dsde.rawls.status.StatusService
import org.broadinstitute.dsde.rawls.user.UserService
import org.broadinstitute.dsde.rawls.util.MockitoTestUtils
import org.broadinstitute.dsde.rawls.workspace.{MultiCloudWorkspaceAclManager, MultiCloudWorkspaceService, RawlsWorkspaceAclManager, WorkspaceService}
import org.broadinstitute.dsde.rawls.workspace.{
MultiCloudWorkspaceAclManager,
MultiCloudWorkspaceService,
RawlsWorkspaceAclManager,
WorkspaceService
}
import org.broadinstitute.dsde.workbench.dataaccess.{NotificationDAO, PubSubNotificationDAO}
import org.broadinstitute.dsde.workbench.google.mock.{MockGoogleBigQueryDAO, MockGoogleIamDAO, MockGoogleStorageDAO}
import org.broadinstitute.dsde.workbench.model.google.GoogleProject
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,14 @@ import akka.http.scaladsl.model.{StatusCode, StatusCodes}
import akka.http.scaladsl.testkit.ScalatestRouteTest
import bio.terra.profile.model.ProfileModel
import bio.terra.workspace.client.ApiException
import bio.terra.workspace.model.{AzureContext, GcpContext, WorkspaceDescription, WorkspaceStageModel, WsmPolicyInput, WsmPolicyPair}
import bio.terra.workspace.model.{
AzureContext,
GcpContext,
WorkspaceDescription,
WorkspaceStageModel,
WsmPolicyInput,
WsmPolicyPair
}
import cats.effect.IO
import cats.implicits.catsSyntaxOptionId
import com.google.api.client.googleapis.json.{GoogleJsonError, GoogleJsonResponseException}
Expand Down Expand Up @@ -45,7 +52,13 @@ import org.broadinstitute.dsde.rawls.webservice._
import org.broadinstitute.dsde.rawls.{NoSuchWorkspaceException, RawlsExceptionWithErrorReport, RawlsTestUtils}
import org.broadinstitute.dsde.workbench.dataaccess.{NotificationDAO, PubSubNotificationDAO}
import org.broadinstitute.dsde.workbench.google.mock.{MockGoogleBigQueryDAO, MockGoogleIamDAO, MockGoogleStorageDAO}
import org.broadinstitute.dsde.workbench.model.google.{BigQueryDatasetName, BigQueryTableName, GcsBucketName, GoogleProject, IamPermission}
import org.broadinstitute.dsde.workbench.model.google.{
BigQueryDatasetName,
BigQueryTableName,
GcsBucketName,
GoogleProject,
IamPermission
}
import org.broadinstitute.dsde.workbench.model.{Notifications, WorkbenchEmail, WorkbenchGroupName}
import org.broadinstitute.dsde.workbench.openTelemetry.{FakeOpenTelemetryMetricsInterpreter, OpenTelemetryMetrics}
import org.joda.time.DateTime
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,8 @@ class GoogleUtilitiesSpec
with StatsDTestUtils {
implicit val executionContext: ExecutionContext = ExecutionContext.global
implicit def histo: Histogram = ExpandedMetricBuilder.empty.asHistogram("histo")
implicit override val patienceConfig: PatienceConfig = PatienceConfig(scaled(Span(1000, Millis)), scaled(Span(15, Millis)))
implicit override val patienceConfig: PatienceConfig =
PatienceConfig(scaled(Span(1000, Millis)), scaled(Span(15, Millis)))

override def afterAll() {
TestKit.shutdownActorSystem(system)
Expand Down

0 comments on commit c48d79b

Please sign in to comment.