AJ-1485: Ignore redundant AvroUpsert messages.
#2656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jladieu
commented
Dec 6, 2023
core/src/test/scala/org/broadinstitute/dsde/rawls/monitor/AvroUpsertMonitorSpec.scala
Outdated
Show resolved
Hide resolved
jladieu
force-pushed
the
AJ-1485-ack-double-delivered-messages
branch
2 times, most recently
from
220ad76 to
565d3b2
Compare
|
/jenkins retest |
davidangb
approved these changes
Dec 6, 2023
core/src/test/scala/org/broadinstitute/dsde/rawls/monitor/AvroUpsertMonitorSpec.scala
Outdated
Show resolved
Hide resolved
Comment on lines
+875
to
+868
| // Publish message on the request topic | ||
| services.gpsDAO.publishMessages( | ||
| importReadPubSubTopic, | ||
| List(MessageRequest(importUuid.toString, testAttributes(importUuid))) | ||
| ) | ||
|
|
||
| // check that a pubsub message was acked. | ||
| eventually(Timeout(scaled(timeout)), Interval(scaled(interval))) { | ||
| services.gpsDAO.acks should not be empty | ||
| } |
There was a problem hiding this comment.
Thinking out loud … I poked at this a bit, and really wanted to find a way to assert that it is acking the second message - the duplicate one - but given the structure of MockGooglePubSubDAO I couldn't find a way to do that. I don't think it's worth refactoring a whole bunch of stuff to make that test work.
jladieu
force-pushed
the
AJ-1485-ack-double-delivered-messages
branch
from
0bd38c1 to
8aa6539
Compare
Double deliveries can happen occasionally: https://cloud.google.com/pubsub/docs/subscription-overview#default_properties Rather than let such redundant messages get stuck in the queue, ack them to clear them out.
jladieu
force-pushed
the
AJ-1485-ack-double-delivered-messages
branch
from
8aa6539 to
ab354b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AJ-1485 Maintenance Ticket
Double deliveries can happen occasionally, per:
https://cloud.google.com/pubsub/docs/subscription-overview#default_properties
Rather than let such redundant messages get stuck in the queue, ack them to clear them out.
This is done as a response to a
Rawls import pub/sub messagealert to prevent future such messages from getting stuck in the queue.