AJ-1524: tracing for submission monitor #2667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pervasive 503s from swat tests. Jenkins retest. |
davidangb
commented
Dec 14, 2023
| case _ => | ||
| logger.error(s"error monitoring submission after $count times", throwable) | ||
| logger.error(s"error monitoring submission after $count times: ${throwable.getMessage}", throwable) |
There was a problem hiding this comment.
ok, these changes aren't about tracing; this is about making it a little easier to see the error in question when searching logs
kpierre13
approved these changes
Dec 15, 2023
davidangb
changed the title
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://broadworkbench.atlassian.net/browse/AJ-1524
Adds hopefully comprehensive tracing for the submission monitor
handleOutputsmethod . Given that we see pretty long transactions related to workflows, hopefully this tracing helps us figure out what's taking so much time.Reviewers: the auto-formatter reformatted a bunch of code, I suggest ignoring whitespace when viewing the diff.
PR checklist
model/, then you should publish a new officialrawls-modeland updaterawls-modelin Orchestration's dependencies.